Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid selection of same track endpoint in multi ports switch #6078

Closed
bloussou opened this issue Dec 7, 2023 · 0 comments · Fixed by #6351
Closed

Forbid selection of same track endpoint in multi ports switch #6078

bloussou opened this issue Dec 7, 2023 · 0 comments · Fixed by #6351
Assignees
Labels
area:editoast Work on Editoast Service area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:infra-editor Infra Edition severity:major Major severity bug

Comments

@bloussou
Copy link
Contributor

bloussou commented Dec 7, 2023

What happened?

This shouldn't be possible :
image
Port A and Port B2 have the same track extremity id (same track and different extremities is OK for a loop).

What did you expect to happen?

To be decided (tick what is necessary).

  1. Front shouldn't allow selection of the same track extremity:
  • ✅ for the same switch > forbid this : able to select, warn user immediately, forbid save
  • ❌ on any switch port (even other switch) > Not required currently
  1. Editoast should trigger a warning or an error to say that the track extremity is used multiple times on switch ports:
  • ✅ on the same switch > add specific error (SelfOverlappingSwitch)
  • ✅ on any switch > already done (Overlapping of switches)
  1. Core:
  • ✅ check that loading an infra fails with SelfOverlappingSwitch (and add this if needed)

How can we reproduce it (as minimally and precisely as possible)?

try to create a 3 ports switch with two tracks

What operating system, browser and environment are you using?

Firefox

OSRD version (top right corner Account button > Informations)

staging b59698b

@bloussou bloussou added kind:enhancement Improvement of existing features area:front Work on Standard OSRD Interface modules module:infra-editor Infra Edition labels Dec 7, 2023
@bloussou bloussou changed the title Forbid selection of smae track in multi ports switch Forbid selection of same track in multi ports switch Dec 7, 2023
@bloussou bloussou added kind:bug Something isn't working area:editoast Work on Editoast Service severity:major Major severity bug and removed kind:enhancement Improvement of existing features labels Dec 7, 2023
@bougue-pe bougue-pe changed the title Forbid selection of same track in multi ports switch Forbid selection of same track extremity in multi ports switch Dec 12, 2023
@flomonster flomonster changed the title Forbid selection of same track extremity in multi ports switch Forbid selection of same track endpoint in multi ports switch Dec 20, 2023
@Wadjetz Wadjetz self-assigned this Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:infra-editor Infra Edition severity:major Major severity bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants