Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when user asks to remediate rules that don't have a remediation #712

Closed
iankko opened this issue Mar 24, 2017 · 2 comments
Closed

Warn when user asks to remediate rules that don't have a remediation #712

iankko opened this issue Mar 24, 2017 · 2 comments
Labels
enhancement help wanted stale An issue or a PR became old enough for us to realize that nobody actually cares about it.

Comments

@iankko
Copy link

iankko commented Mar 24, 2017

Disclaimer: Didn't check latest version, so feel free to close this, if already implemented, or decided as wontfix.

Use case:
User scans the system (baremetal, vm, container, whatever) and requests online remediation. Since not all remediations might be implemented in the benchmark, user might expect the system will be corrected / remediated as a whole, though this obviously won't happen.

Thus rather to confuse users, and make them to later find out, why the scan is still failing, it's better right at the scan issue a NOTE / WARNING in the case, rule is present in the original (modified) profile, and online remediation was requested, but the corresponding remediation for that rule is missing (thus oscap won't correct this system property).

Current user experience (see above disclaimer though, didn't check latest version):
User requests remediation. After completion, some rules are still failing.

Expected user experience:
User requests remediation. Rules not having remediation implemented yet, would be printed by oscap either beforehand -- something like:

The following rules are missing remediation:

  • Rule_1
  • Rule_2
    Remediation won't be performed for these rules.

or during the scan (if oscap knows if remediation is available only at the moment rule is "touched") -- something like:

Rule: Audit rules privileged commands (or whatever rule title here):
Result: Pass / Fail
Note: The rule is missing remediation. The corrective operation won't be performed.

Thank you for consideration!
Jan

@mpreisler
Copy link
Member

Makes sense to me. We should issue the same warning for generate fix as well. This would clearly communicate that the resulting fixes aren't complete for those test results.

@shawndwells
Copy link
Member

Love this. Would really be great for UX.

@jan-cerny jan-cerny modified the milestones: 1.2.16, 1.2.15 Aug 17, 2017
@matejak matejak modified the milestones: 1.2.16, 1.2.17 Nov 13, 2017
@mpreisler mpreisler changed the title [RFE] Issue a warning / note while performing scan and online remediation was simultaneously requested Warn when user asks to remediate rules that don't have a remediation May 25, 2018
@jan-cerny jan-cerny modified the milestones: 1.2.17, 1.2.18 May 29, 2018
@evgenyz evgenyz added the stale An issue or a PR became old enough for us to realize that nobody actually cares about it. label Feb 9, 2024
@evgenyz evgenyz closed this as completed Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted stale An issue or a PR became old enough for us to realize that nobody actually cares about it.
Projects
None yet
Development

No branches or pull requests

6 participants