[BugFix] [RHEL/7] Rewrite RHEL-7 remediation for 'smartcard_auth' rule #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rule since per downstream bug: https://bugzilla.redhat.com/show_bug.cgi?id=1357019 we can't use 'authconfig' binary direct call, because it will discard the changes as performed and required by other remediation scripts also touching /etc/pam.d/system-auth{,-ac} file Therefore return to previous version updating necessary files directly via 'sed' tool (rather than using 'authconfig' binary) Note: While on the rule also update XCCDF link providing further info how to setup smartcard auth (since the current one returns HTTP 404 Not Found)
iankko
added
bugfix
|
ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since per downstream bug:
https://bugzilla.redhat.com/show_bug.cgi?id=1357019
we can't use 'authconfig' binary direct call, because it will discard the changes as performed and required by other remediation scripts also touching
/etc/pam.d/system-auth{,-ac}filesTherefore return to previous version updating necessary files directly via 'sed' tool (rather than using 'authconfig' binary)
Note: While on the rule also update XCCDF link providing further info how to setup smartcard auth (since the current one returns HTTP 404 Not Found)
Testing result:
The change has been tested on RHEL-7 local system and seems to be working properly (AFAICT).
Please review.
Thank you, Jan.