Improve reliability of smartcard_auth remediation #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid adding 'auth [success=done authinfo_unavail=ignore ignore=ignore default=die] pam_pkcs11.so nodebug' after every occurence of 'auth [success=1 default=ignore] pam_succeed_if.so service notin login:gdm:xdm:kdm:xscreensaver:gnome-screensaver:kscreensaver quiet use_uid' There can be situations in witch the PAM stack is already configured with a pam_succeed_if.so module exactly like that. Addresses comment 9 of https://bugzilla.redhat.com/show_bug.cgi?id=1357019
|
@dahaic Since you were working on this previously, could you share your thoughts on it? |
|
Thank you, this patch addresses my comment perfectly. |
dahaic
approved these changes
Apr 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid adding
'auth [success=done authinfo_unavail=ignore ignore=ignore default=die]
pam_pkcs11.so nodebug'
after every occurence of
'auth [success=1 default=ignore] pam_succeed_if.so service notin
login:gdm:xdm:kdm:xscreensaver:gnome-screensaver:kscreensaver quiet use_uid'
There can be situations in witch the PAM stack is already configured
with a pam_succeed_if.so module exactly like that.
Addresses comment 9 of https://bugzilla.redhat.com/show_bug.cgi?id=1357019