Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To be on the safe side, force ansible XCCDF values to be interpreted as str… #3050

Merged
merged 1 commit into from Jun 26, 2018
Merged

To be on the safe side, force ansible XCCDF values to be interpreted as str… #3050

merged 1 commit into from Jun 26, 2018

Conversation

mpreisler
Copy link
Member

…ings

Avoid quotes though because that enables all sorts of escaping rules
that we would have to work around.

This fixes a regression which causes invalid Ansible syntax and breaks some of our roles - especially rhel6 and 7. Regression happened in b0eb3b7 and was reviewed by me (oops :-D)

To be on the safe side, force ansible XCCDFs to be interpreted as str…
95e9d51 
…ings

Avoid quotes though because that enables all sorts of escaping rules
that we would have to work around.
@mpreisler mpreisler added bugfix Fixes to reported bugs. BLOCKER Impediments to release, like failure to build content, or content built is out of standard's syntax labels Jun 26, 2018
@mpreisler mpreisler added this to the 0.1.40 milestone Jun 26, 2018
@mpreisler mpreisler changed the title To be on the safe side, force ansible XCCDFs to be interpreted as str… To be on the safe side, force ansible XCCDF values to be interpreted as str… Jun 26, 2018
@cipherboy cipherboy self-assigned this Jun 26, 2018
@mpreisler mpreisler added the Ansible Ansible remediation update. label Jun 26, 2018
@mpreisler mpreisler mentioned this pull request Jun 26, 2018
Merged
@cipherboy
Copy link
Contributor

LGTM, builds locally and tests pass:

(snip)
[420/420] [sl7-guides] generating HTML guides for all profiles in ssg-sl7-ds.xml
real 111.78
user 303.19
sys 41.43

(snip)
157/170 Test #104: ansible-role-syntax-check-rhel7 ..........................................   Passed   78.08 sec
(snip)
100% tests passed, 0 tests failed out of 170

Total Test time (real) = 289.08 sec

@cipherboy cipherboy merged commit fea55eb into ComplianceAsCode:master Jun 26, 2018
@cipherboy
Copy link
Contributor

@mpreisler Thanks for the fix! :)

@mpreisler mpreisler deleted the fix_ansible_syntax_related_to_quotes branch June 26, 2018 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Ansible Ansible remediation update. BLOCKER Impediments to release, like failure to build content, or content built is out of standard's syntax bugfix Fixes to reported bugs.
Projects
None yet
Milestone
0.1.40
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mpreisler @cipherboy