Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Release Guide confusing instructions #152

Open
jan-cerny opened this issue Dec 7, 2017 · 2 comments
Open

Windows Release Guide confusing instructions #152

jan-cerny opened this issue Dec 7, 2017 · 2 comments

Comments

@jan-cerny
Copy link
Member

https://github.com/OpenSCAP/scap-workbench/wiki/Windows-build-and-installer-guide

Section 4. Get ssh.exe & win-ssh-askpass.exe says:
Do not get anything else from the old MSI, everything else must be fresh built!

Then Section 5. Get libraries using mingw-bundledlls says:
We will use previous release to get missing libraries.

I would prefer to explicitly list those libraries that are missing. I would suggest to copy them already in step 4. If you run mingw-bundledlls and you don't already have the missing libraries copied from previous release you get a traceback.

It might happen that somebody will understand the release guide and mingw-bundledlls wrong and will copy more libraries than only the missing libraries.

@matejak
Copy link
Contributor

matejak commented Dec 8, 2017

@WesleyCeraso, who released the previous workbench mentioned, that he took libraries from the previous release. However, rebuilding it is probably better. We will investigate this, but using the previous release is the quick way to go that should work.

@jan-cerny
Copy link
Member Author

Ok, thanks. To clarifiy this: There are 2 types of bundled libraries in SCAP Workbench for Windows:

  1. libraries that are dependecies of oscap.exe. It is libopenscap.dll that we rebuilt and also libraries than come from MinGW installation on Fedora. All of them are obtained by migw-bundledlls --copy oscap.exe
  2. missing libraries that are dependencies of ssh.exe and win-ssh-askpass.exe. We copy these libraries from the old installer. They're not properly documented in the Windows Release Guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants