Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Higher resolution UI assets? #275

Open
cipherboy opened this issue Mar 18, 2021 · 0 comments · May be fixed by #277
Open

Higher resolution UI assets? #275

cipherboy opened this issue Mar 18, 2021 · 0 comments · May be fixed by #277
Labels
enhancement question ux

Comments

@cipherboy
Copy link
Member

Figured I'd open an issue in case anyone has any thoughts.

I have a 14" 1440p x1c 4th gen. When I load scap-workbench on Fedora 33, I notice a lot of blobby pixels in most of the icons. This is because they're all 16x16 and they're rendering in a space double the size (32x32).

I'm able to find direct replacements for the following assets from the tango project:

  • benchmark.png == edit-paste
  • edit-undo.png == edit-undo
  • edit-redo.png == edit-redo
  • group.png == folder
  • value.png == text-x-generic
  • rule.png == preferences-system

The following assets don't have direct replacements:

  • collapsed-arrow.png
  • expanded-arrow.png
  • profile.png

The two arrows are easy enough to recreate (Inkscape and create a quick triangle shape, matching color), but what about profile.png? Could it be replaced with something from tango like x-office-spreadsheet?

Old:
profile

Suggested:
x-office-spreadsheet

I can also remove the pichart like so:
x-office-spreadsheet-edited

Lastly, what is everyone's preferences about size? I'd probably re-export at 64x64 or 128x128. I can directly use SVG assets as well (Tango provides such), but the issue is loading the customization takes a while if using SVGs. I'm not sure yet if 128x128 does the same; if it doesn't I'd prefer to go with that. Note that this only affects the source asset size, the file size in the GUI doesn't change.

Thoughts?
@cipherboy cipherboy self-assigned this Mar 18, 2021
cipherboy added a commit to cipherboy/scap-workbench that referenced this issue Mar 24, 2021
@cipherboy
Add new profile icon from Tango
5a3358d 
Started with Tango's x-office-spreadsheet, removed the database icon,
and added in the selection effect from the original Profile icon. This
remains faithful to the intent of the original icon while using
known-good assets from the Tango project as the base (and providing a
SVG as well for the future).

Resolves: OpenSCAP#275

Signed-off-by: Alexander Scheel <alex.scheel@canonical.com>
@cipherboy cipherboy linked a pull request Mar 24, 2021 that will close this issue
Draft
@cipherboy cipherboy removed their assignment Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement question ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to high-quality assets cipherboy/scap-workbench
1 participant
@cipherboy