Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistency in baseline methods #18

Open
jknowles opened this issue Apr 4, 2017 · 0 comments
Open

Consistency in baseline methods #18

jknowles opened this issue Apr 4, 2017 · 0 comments

Comments

@jknowles
Copy link
Collaborator

jknowles commented Apr 4, 2017 •
edited

Currently, baseline methods do not consistently return the same object type:

  • assign_baseline("ell", data) returns an integer
  • assign_baseline("program", data) returns a data.frame
  • assign_baseline("grade", data) returns a data.frame

This inconsistency is not exposed to users since get_baseline is internal only, but it should be resolved. Least common denominator solution is to always return the original data with baseline appended.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jknowles