B2B module ignores compact contact-type header (c)

[bbuitenhuis]

the b2b modules adds an new header:
Content-Type: application/sdp

without deleting/updating the existing (compact) header:
c: application/sdp

[ionutrazvanionita]

Try applying this patch https://gist.github.com/ionutrazvanionita/688a4c832049997ca62e. Hope it solves your problem!

[bogdan-iancu]

@ionutrazvanionita , the best approach is to actually parse ehdrs in a SIP-wise manner :
/* use SIP parser to look at what is in the FIFO request */
memset( &tmp_msg, 0, sizeof(struct sip_msg));
tmp_msg.len = hdrs->len;
tmp_msg.buf = tmp_msg.unparsed = hdrs->s;
if (parse_headers( &tmp_msg, HDR_EOH_F, 0) == -1 )
return init_mi_tree( 400, "Bad headers", 11);

(see modules/tm/tm.c +473 )

[bbuitenhuis]

I believe the bug only occurs in the b2b module. Or is the root cause in tm?

[ionutrazvanionita]

@bbuitenhuis It has nothing to do with the tm module, it was only a hint about how to approach the problem!

[bbuitenhuis]

I see! Needed coffee ;-)
Thanks!

[ionutrazvanionita]

Try this new patch https://gist.github.com/ionutrazvanionita/5b3e722deaeca775acf7, which parses the headers SIP-wisely, which should solve any problem concerning Content-Type parsing.

[bbuitenhuis]

@ionutrazvanionita I've patched the patch, but didn't resolve the issue.
In the message still both c: and content-type: headers are present.

I've make sure the patch really patched.
Any thoughts?

[ionutrazvanionita]

@bbuitenhuis sorry did a little mistake when searching for the Content-Type header. Try this one https://gist.github.com/ionutrazvanionita/1857e3b27d5c1e4906c1.