uac_replace_XXX() treating input string as a literal some of the time

[mishehu]

This affects 2.1.2 hash c846598 running on Centos 6.

If I have the following in my opensips.cfg file:

$var(newTo) = "sip:$rU@$var(someVar)";
uac_replace_to("$var(newTo)");

What I end up with in the actual SIP is a To header that looks like this:

To: "Foo" sip:$rU@$var(someVar)

I spoke with Bogdan briefly about this on IRC, and he confirms that the uac_replace_XXX functions should be feeding the input through pv_printf_s() and it should replace the $rU and the $var(someVar) with their respective values. He said this might be a bug, so here I am. :-)

[mishehu]

I'd like to add that running xlog() with the input of "sip:$rU@$var(someVar)" does in fact show up in the logs with the variables both being evaluated properly, such that it will show as:

sip:12345@PLANETDRUIDIA

instead of the behavior that we're seeing in uac_replace_xxx() .

[bogdan-iancu]

@mishehu , it may be an misunderstanding on how you construct strings from variables.
Instead of
$var(newTo) = "sip:$rU@$var(someVar)";
(where the input is simply evaluated as string)
the correct way (if you want to have variables evaluated is:
$var(newTo) = "sip:"+$rU+"@"+$var(someVar);

Please confirm that the above works for you ; or if there are any other issues.

Regards,
Bogdan

[mishehu]

Yes, obviously $var(newTo) = "sip:" + $rU + "@" + $var(someVar); works. Like I was explaining, I need to accommodate patterns that can't be standardized. How does one enter:

"sip:" + $rU + "@" + $var(someVar);
"sip:" + $var(foo) + $var(bar) + "@" + $var(someVar);
...

Into the dialplan database? These values are not known in advance. That's the ultimate goal here.

[bogdan-iancu]

@mishehu , if I get it right, you want to take this FMT string (like "sip:$rU@$var(someVar)" ) from somewhere (DB, etc) and than use it to evaluate it ; like you load that fmt string from DB and you use it for building the new TO header. Is this correct ?

[mishehu]

That is correct. Dialplan module seemed to be the most fitting for what we needed, since we're already making use of dialplan. I didn't see another module that would be able to do this. Any guidance would be appreciated... or perhaps this issue is not a bug but an RFE (request for enhancement) ?

[bogdan-iancu]

Yes, I guess this is more like a feature request than a bug. Maybe, for generic usage, we can evaluate a new string transformation to evaluate the FMT from a variable.....

[mishehu]

That would not be a bad idea. It would possibly be something many other folks would find useful. My time is a bit limited right now, but I will try to see if I can work up a patch for it unless somebody else here finds it equally useful and beats me to it.