Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insistences between Spec and manifest/yaml Validation #288

Open
aaranmcguire opened this issue Feb 14, 2024 · 0 comments
Open

Insistences between Spec and manifest/yaml Validation #288

aaranmcguire opened this issue Feb 14, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@aaranmcguire
Copy link

aaranmcguire commented Feb 14, 2024 •
edited
Loading

Summary

I've been reading the spec, and noticed within the SLO type, the docs say timeWindow is optional. This is echoed in the OpenAPI spec.

OpenSLO Spec

However, oslo has the field as required within the manifest.

I'm happy to fix this, however I don't know which should be considered as correct. Any guidance?

PS, have we ever thought of OpenAPI to Golang Generators so updating the OpenAPI spec would automatically update the Go structs?
@aaranmcguire aaranmcguire added the bug Something isn't working label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aaranmcguire