Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oslo not validating multiple yaml document with "---" #76

Open
ashwaniagarwal226 opened this issue Dec 17, 2021 · 0 comments
Open

oslo not validating multiple yaml document with "---" #76

ashwaniagarwal226 opened this issue Dec 17, 2021 · 0 comments
Labels
bug Something isn't working go Pull requests that update Go code good first issue Good for newcomers
Milestone

Comments

@ashwaniagarwal226
Copy link

oslo is validating only 1st document but not validating the whole yaml file like below

apiVersion: openslo/v1alpha
kind: Service
metadata:
  name: my-rad-service
  displayName: My Rad Service
spec:
  description: This is a great description of an even better service.
---
# Not validating below yaml
apiVersion: openslo/v1alpha
kind: SLO
metadata:
  displayName: Ratio
  name: ratio
spec:
  budgetingMethod: Timeslices
  description: A great description of a ratio based SLO
  objectives:
  - ratioMetrics:
      good:
        source: prometheus
        queryType: promql
        query: latency_west_c7{code="ALL",instance="localhost:3000",job="prometheus",service="globacount"}
      incremental: true
      total:
        source: prometheus
        queryType: promql
        query: latency_west_c7{code="ALL",instance="localhost:3000",job="prometheus",service="globacount"}
    displayName: painful
    target: 0.98
    value: 1
  service: my-test-service
  timeWindows:
  - count: 28
    isRolling: true
    unit: Day
@ian-bartholomew ian-bartholomew added this to the v1.0.0 milestone Dec 17, 2021
@ian-bartholomew ian-bartholomew added bug Something isn't working good first issue Good for newcomers go Pull requests that update Go code labels Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working go Pull requests that update Go code good first issue Good for newcomers
Projects
Status: Todo
Development

No branches or pull requests

2 participants