You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
488d3a4#diff-6641255a80b4407d59eaf41c20a64b38R386 introduces a regression:
Since "d_namlen" is not specified in POSIX, this is probably not going to compile on most systems (tested on Ubuntu 14.10).
dp->d_namlen != 16 needs to be either removed or replaced with something else. AFAIK d_namlen is technically the same as strlen(dp->d_name), while strncmp(dp->d_name, msgid_str, 8) is used just after that. Therefore you could also just replace it with:
if (strlen(dp->d_name) !=16||memcmp(dp->d_name, msgid_str, 8) !=0) {
continue;
}
I think this should fix the issue and be about as fast or faster as the previous solution, since strncmp checks for \0 in both strings too.
The text was updated successfully, but these errors were encountered:
BTW: There is another build error since SSL_CTX_use_certificate_chain got renamed to SSL_CTX_use_certificate_chain_mem, which is a function that does not exist in OpenSSL, but only LibreSSL. But I'm not sure if this is a real bug, which I should submit, or working as intended. Fact is that it's not building the project without modifying the code to match OpenSSL.
488d3a4#diff-6641255a80b4407d59eaf41c20a64b38R386 introduces a regression:
Since "d_namlen" is not specified in POSIX, this is probably not going to compile on most systems (tested on Ubuntu 14.10).
dp->d_namlen != 16
needs to be either removed or replaced with something else. AFAIKd_namlen
is technically the same asstrlen(dp->d_name)
, whilestrncmp(dp->d_name, msgid_str, 8)
is used just after that. Therefore you could also just replace it with:I think this should fix the issue and be about as fast or faster as the previous solution, since
strncmp
checks for \0 in both strings too.The text was updated successfully, but these errors were encountered: