Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement IView, IResidence, IField & IBaseConfiguration interfaces #12

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Implement IView, IResidence, IField & IBaseConfiguration interfaces #12

wants to merge 22 commits into from

Conversation

ekigamba
Copy link
Contributor

@ekigamba ekigamba commented Sep 17, 2020 •
edited

To do before merging:

  • Change client core version to mainstream version

@coveralls
Copy link

coveralls commented Mar 1, 2021 •
edited

Pull Request Test Coverage Report for Build #44

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 14.836%
Totals Coverage Status
Change from base Build 85: 0.0%
Covered Lines: 77
Relevant Lines: 519
💛 - Coveralls

@ekigamba ekigamba requested a review from allan-on March 1, 2021 10:49
@allan-on allan-on mentioned this pull request Mar 3, 2021
Open
9 tasks
allan-on
allan-on approved these changes Mar 3, 2021
View reviewed changes
Copy link

@allan-on allan-on left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ekigamba ekigamba added the DNM label Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allan-on allan-on allan-on approved these changes

Assignees
No one assigned
Labels
DNM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ekigamba @coveralls @allan-on