Implement scheduled plan activation #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Clear previous jobs of PlanPeriodicEvaluationJob.action-code.{action.code}
- Reschedule jobs for the action
- It only supports daily timings
- Schedule/reschedule jobs when a new plan is synced or an old plan is updated
More at opensrp/opensrp-client-goldsmith#83
ekigamba
changed the title
…previous jobs for same action
…plan-effective-period - Ideally, the plan.effectivePeriod and action.timingPeriod will be used to determine the start and end period during which periodic task can be performed
- The plan.effectivePeriod and action.timingPeriod are used to determine if the end of the schedule has reached - Every evernote job is saved with the plan-id, action, action-identifier and action code - For now, the service evaluates the whole plan instead of evaluating just the specific action. This means there will be repeated evaluation and can cause duplicates
- Update opensrp-plan-evaluator to 1.5.1-alpha.3-SNAPSHOT
- Fix the ANC Contact follow-up action
- Remove hardcoded PlanDefinition for Goldsmith Tasking app
LZRS
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SRS Doc
NB: PR previously contained a useful hack because the server was dropping the
Trigger.timingproperty on plan definitionsIgnored test will be fixed on another PR but being tracked at #836