Fixes app crashes reported on Android Version 5 #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added inclusion rules for serialization in proguard added exception check in getUserInitials in utils file added null check in setSelectedLocation
ellykits
requested changes
Aug 24, 2021
opensrp-app/src/main/java/org/smartregister/service/HTTPAgent.java
Outdated
Show resolved
Hide resolved
opensrp-app/src/main/java/org/smartregister/service/HTTPAgent.java
Outdated
Show resolved
Hide resolved
opensrp-app/src/main/java/org/smartregister/service/HTTPAgent.java
Outdated
Show resolved
Hide resolved
opensrp-app/src/main/java/org/smartregister/service/HTTPAgent.java
Outdated
Show resolved
Hide resolved
opensrp-app/src/main/java/org/smartregister/service/HTTPAgent.java
Outdated
Show resolved
Hide resolved
opensrp-app/src/main/java/org/smartregister/service/HTTPAgent.java
Outdated
Show resolved
Hide resolved
opensrp-app/src/main/java/org/smartregister/service/HTTPAgent.java
Outdated
Show resolved
Hide resolved
opensrp-app/src/main/java/org/smartregister/service/HTTPAgent.java
Outdated
Show resolved
Hide resolved
opensrp-app/src/main/java/org/smartregister/service/HTTPAgent.java
Outdated
Show resolved
Hide resolved
opensrp-app/src/main/java/org/smartregister/service/HTTPAgent.java
Outdated
Show resolved
Hide resolved
|
@junaidwarsivd Remember to bump up the version in |
updated version name in gradle.proerties
junaidwarsivd
changed the title
ellykits
approved these changes
Aug 25, 2021
opensrp-app/proguard-rules.pro
Outdated
Comment on lines
20
to
34
|
|
||
| -keep class * implements java.io.Serializable | ||
|
|
||
| -keepclassmembers class * implements java.io.Serializable { | ||
| static final long serialVersionUID; | ||
| private static final java.io.ObjectStreamField[] serialPersistentFields; | ||
| !static !transient <fields>; | ||
| !private <fields>; | ||
| !private <methods>; | ||
| private void writeObject(java.io.ObjectOutputStream); | ||
| private void readObject(java.io.ObjectInputStream); | ||
| java.lang.Object writeReplace(); | ||
| java.lang.Object readResolve(); | ||
| } |
There was a problem hiding this comment.
Move this to the project using the library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added inclusion rules for serialization in proguard
added exception check in getUserInitials in utils file
added null check in setSelectedLocation
added exception handling for illegalArgument in HttpAgent
issue reported on ZEIR opensrp/opensrp-client-path-zeir#185