Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

834 Fix sync progress bar #835

Merged
merged 3 commits into from
Sep 15, 2021
Merged

834 Fix sync progress bar #835

merged 3 commits into from
Sep 15, 2021

Conversation

allan-on
Copy link
Contributor

@allan-on allan-on commented Sep 15, 2021 •
edited

  • Get total counts during fetch retries
  • Maintain and update a count of total records being fetched and use this when computing the progress percentage

See #834 for details

@allan-on
🐛 Update total records on feth retry
77ddd88 
Maintain and update a count of total records for use in % computation
@allan-on
📸 Update snapshot version name
5503ec1
@coveralls
Copy link

coveralls commented Sep 15, 2021 •
edited

Coverage Status

Coverage increased (+0.003%) to 69.315% when pulling 98599f9 on 834-fix-sync-progress-bar into b5615f8 on master.

@allan-on allan-on merged commit 9cc7955 into master Sep 15, 2021
@allan-on allan-on deleted the 834-fix-sync-progress-bar branch September 15, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiarie qiarie qiarie approved these changes

@Rkareko Rkareko Awaiting requested review from Rkareko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@allan-on @coveralls @qiarie