Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process Global configs after login and not during app startup #120

Merged
merged 2 commits into from Mar 13, 2019
Merged

Process Global configs after login and not during app startup #120

merged 2 commits into from Mar 13, 2019

Conversation

githengi
Copy link
Contributor

@githengi githengi commented Mar 12, 2019 •
edited

Fixes #119

@coveralls
Copy link

Pull Request Test Coverage Report for Build 622

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 2.413%
Changes Missing Coverage Covered Lines Changed/Added Lines %
opensrp-reveal/src/main/java/org/smartregister/reveal/activity/LoginActivity.java 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
opensrp-reveal/src/main/java/org/smartregister/reveal/activity/LoginActivity.java 1 26.67%
Totals Coverage Status
Change from base Build 540: 0.0%
Covered Lines: 45
Relevant Lines: 1865
💛 - Coveralls

@githengi githengi merged commit 49e4d49 into master Mar 13, 2019
@githengi githengi deleted the 119-fix-database-call-before-login branch March 13, 2019 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincent-karuri vincent-karuri vincent-karuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@githengi @coveralls @vincent-karuri