Gateways are now organized #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I made the `GatewayBase` organized. As a result, the contracts that directly or indirectly extend the `GatewayBase` must now provide an address of a worker manager contract that implements the interface `IsWorkerInterface`. All relevant modifiers were replaced by `onlyWorker`. Tests were updated to reflect the change. In order to easily test organized contracts, I created a `MockWorkerManager` that can be used in tests and has a single valid worker address. I also re-organized the `contracts/test` directory a little bit with additional sub-directories. Fixes OpenST#486
Merged
schemar
commented
Dec 7, 2018
There was a problem hiding this comment.
@deepesh-kn @gulshanvasnani This PR is now ready for review.
I added isOwner to the IsMemberInterface (formally isWorkerInterface) and the onlyOrganization modifier.
deepesh-kn
reviewed
Dec 7, 2018
schemar
commented
Dec 7, 2018
There was a problem hiding this comment.
Addressed the mentioned changes 👍
Regarding this question:
Also, a lot of existing tests (touched in this PR) contains expectThrow instead of expectRevert and no error message is provided. We can create a ticket for that. What's your opinion?
There is #406. We could extend that to include error messages.
deepesh-kn
approved these changes
Dec 7, 2018
There was a problem hiding this comment.
LGTM 💯
There is #406. We could extend that to include error messages.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the
GatewayBaseorganized. As a result, the contracts thatdirectly or indirectly extend the
GatewayBasemust now provide anaddress of a worker manager contract that implements the interface
IsWorkerInterface. All relevant modifiers were replaced byonlyWorker.Tests were updated to reflect the change. In order to easily test
organized contracts, I created a
MockWorkerManagerthat can be used intests and has a single valid worker address.
I also re-organized the
contracts/testdirectory a little bit withadditional sub-directories.
Fixes #486