Skip to content
This repository has been archived by the owner on Mar 14, 2019. It is now read-only.

Scripts: make confirmations case-insensitive and clarify fails #84

Closed
3 tasks
jasonklein opened this issue Jan 9, 2018 · 0 comments
Closed
3 tasks
Assignees
Milestone

Comments

@jasonklein
Copy link

jasonklein commented Jan 9, 2018

(Temporarily assigned to @rachinkapoor and @kedarchandrayan until re-assignment.)

The scripts executed by run_complete_test_deploy.sh require confirmations, asking: “Do you want to proceed? [Y/N]”.

A Y proceeds; anything else, including y, ends the JS script, but does not end execution of the shell script or otherwise make clear to the user that her negative response will prevent her from successfully completing the next step (i.e., staking and minting).

The following steps should be taken:

  • make the JS scripts case-insensitive for confirmations
  • exit the shell script upon a negative confirmation
  • be more explicit with what is meant in the exit message (I am not certain it is obvious how the user is meant to change the environment variables by, "Exiting deployment scripts. Change the env vars and re-run.")

This relates to #83.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants