Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance and Further Development #3

Open
randName opened this issue Feb 1, 2019 · 4 comments
Open

Maintenance and Further Development #3

randName opened this issue Feb 1, 2019 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@randName
Copy link
Member

randName commented Feb 1, 2019

Feel free to discuss on this issue. I will not offer much in terms of direction but I can offer advice and explain how the different parts work.

@randName randName added the help wanted Extra attention is needed label Feb 1, 2019
@piroton
Copy link
Member

piroton commented Feb 4, 2019

Does the Parser update the database each time a new timetable is uploaded? Or does it simply perform the check to ask if the data has already been put in?

Are manual purges to remove the data necessary?

@randName
Copy link
Member Author

randName commented Feb 4, 2019

The parser only extracts the data out, updating the database is done in the view using the Firebase binding. There are no checks, old data is simply overwritten. I wanted to make a staging section for new uploads before they are pushed out (to prevent random people clearing out the db) but never got round to it. Also might want to let people suggest edits if there's changes in schedule or other parsing errors.

Old schedules only cause a problem because the section numbers overlap across terms (e.g. 1138 in one term might be different from the next). The current schema on Firebase namespaces the term but it throws the occasional error and it becomes NaN-NaN. I think this will reduce the need for purging beyond running out of space, and even that can actually be done with a Firebase Cloud Function

@chaychoong
Copy link

I think you can just take the role of the maintainer bah.. go to Family and call for collaborators perhaps?

@Yustynn
Copy link
Member

Yustynn commented May 17, 2019

I've fixed it for this term, but won't be maintaining next term onwards (graduating).

Main issues with maintaining:
• Non-obvious that you have to manually change the term every time we enter a new term
• Non-obvious how to retrieve prod keys
• No way of maintaining your cloud function for the calendar @randName (also, it relies on using prod db)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants