This repository has been archived by the owner on Oct 6, 2023. It is now read-only.
Extract app identifiers #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a xcconfig file. This allows a developer to specify DEVELOPMENT_TEAM_OVERRIDE - If they do so the specified DEVELOPMENT_TEAM_OVERRIDE will be used as the DEVELOPMENT_TEAM in all the places it needs to be. If it's not set - then it defaults to B6QG723P8Z
…RODUCT_BUNDLE_IDENTIFIER - to make it easier to get running on a different Apple Developer account.
…LE_IDENTIFIER to PRODUCT_BUNDLE_IDENTIFIER_BASE - otherwise the Autofill targets had the wrong iCloud settings due to the expanded PRODUCT_BUNDLE_IDENTIFIER (+1 squashed commit) Squashed commits: [8464e48] Setup the iCloud Containers/Ubquity container IDs to be based off of the PRODUCT_BUNDLE_IDENTIFIER
…ld target runs the GenerateBuildConfig.sh to autogenerate a Swift file that exposes compile time values for the APPGROUP amongst others
…tializer that sets the correct service/access group. Use the new OpenSesameKeychain to consolidate the usage of the service/app groups in one spot. Replace further hardcoded CloudKit container identifiers and NSUserDefault suite names to use the values from OpenSesameConfig Expose the DEVELOPMENT_TEAM as part of the OpenSesameConfig
…tifier base is set.
|
I've just spotted another reference that I missed in the rebase - iCloud.com.ethanlipnik.OpenSesame in Persistence+Container.swift |
|
This is some really great work! I'll be sure to test this branch and merge it soon! |
|
After a merge I realized that macOS no longer compiles because for some reason it can't set the iCloud containers. Working on a fix |
|
|
|
Also may be from a temporary revert but your name won't show up in the contributions list for some reason even though your commits are in the git. If you'd like to be added to the list, make a new pull request for something new, could be something small @feralbob |
|
I'll take a look at why macOS isn't working correctly too |
|
Fantastic! Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request extracts a number of Apple Developer Account specific values from the pbxproj to a xcconfig file.
The extracted values include DEVELOPMENT_TEAM, APP_GROUPS and a base for the PRODUCT_BUNDLE_IDENTIFIER. The system includes a method to override them with a fallback to the current values for @EthanLipnik's account.
Ultimately this change makes it much easier for a contributor to setup OpenSesame in their own Apple Developer Account, including the ability to run app on device.
This change should be complete - but will require testing to make sure I've caught everything.