Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port PhraseBuilder from v1.2 branch to master #20

Closed
dsmiley opened this issue Oct 3, 2013 · 6 comments
Closed

Port PhraseBuilder from v1.2 branch to master #20

dsmiley opened this issue Oct 3, 2013 · 6 comments
Labels
Milestone

Comments

@dsmiley
Copy link
Member

dsmiley commented Oct 3, 2013

I'd love to see the improvements made on the 1.2 branch ported to the MemPF branch (v2.0).

MemPF seems to work well in OpenSextant but it hasn't been as throughly evaluated. I suspect if Stanbol ports to MemPF, and if Rupert does his measurements as he's done before, it will be more clear through its tests, etc. how well the MemPF does.

@dsmiley
Copy link
Member Author

dsmiley commented Oct 3, 2013

Rupert, do you already have plans for this or should I get started?

@dsmiley
Copy link
Member Author

dsmiley commented Oct 3, 2013

Doing a git merge would likely be a mess so doing this manually is probably the way to go, except for a few particular cases perhaps where a cherry-pick would probably work (e.g. making TagLL public). It could be done with a sequence of commits adding one feature at a time:

  1. Remove 2 deprecated classes.
  2. Ignore posInc > 1 (stopwords)
  3. skipAltTokens option (synonyms)
  4. Make TagLL public.
  5. Support Solr 4.4 (remember to exclude slf4j-log4j). Needs to support 4.3 still.
  6. Read config via Solr standard invariants/appends/defaults; don't use top level config of request handler (breaking config change)
  7. And of course -- PhraseBuilder.
  8. README updates (merge both)

This was referenced Dec 13, 2013
@dsmiley
Copy link
Member Author

dsmiley commented Dec 13, 2013

Updated TODO list based on changes since the last (removed two items):

  1. Ignore posInc > 1 (stopwords)
  2. skipAltTokens option (synonyms)
  3. Make TagLL public.
  4. Read config via Solr standard invariants/appends/defaults; don't use top level config of request handler (breaking config change)
  5. And of course -- PhraseBuilder.
  6. README updates (related to Release version 2.0 #23)

@dsmiley
Copy link
Member Author

dsmiley commented Dec 14, 2013

Updated TODO list based on changes:
2. Change all solrconfig.xml to use Solr standard invariants/appends/defaults style (incl. README doc) -- don't use top level config of request handler which is deprecated but still works
7. And of course -- PhraseBuilder.
8. README updates (related to #23)

@dsmiley
Copy link
Member Author

dsmiley commented Jan 15, 2015

I'm going to release 2.0 next week, moving into master branch position, and put the current master as a 1.x branch. I'll get to the list above except for "PhraseBuilder" which remains to be the reason to use 1.1. I'll push 2.0 to Maven as well.

@dsmiley dsmiley changed the title Port v1.2 improvements to MemPF branch. Port PhraseBuilder from v1.2 branch to master Sep 1, 2016
@dsmiley
Copy link
Member Author

dsmiley commented May 19, 2018

I think I'll close this as it's not going to happen (RE PhraseBuilder). The ConcatenateFilterFactory could be changed to use GraphTokenStreamFiniteStrings to accomplish the ultimate effect, and it wouldn't even be that hard AFAICT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant