New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 'using namespace' from include files #204
Comments
Just for the record, I spent a very, very long night taking a look at this issue and, well... the results were less than satisfying. I did manage to get all of the The results of my efforts are in my namespace-cleanup branch if anyone's interested. What's there does compile, at least for me. But If you try to run OpenShot with it, it'll die right at startup as soon as it tries to create the Timeline object. It doesn't understand
|
I took another run at this, and by jove I think I've got it! Still testing, but libopenshot compiled and passed its tests, and I ran OpenShot against the corresponding |
My std-prefixes branch contains the results of that effort, though once I'm more confident that it's really OK I plan to submit it as a PR, at which point I'll link it to this issue. |
The libopenshot header files contain multiple
using namespace
statements foropenshot
andstd
. This is a bad design for several reasons that I will not enumerate here.Look for instance in https://stackoverflow.com/questions/5849457/using-namespace-in-c-headers and https://www.acodersjourney.com/top-10-c-header-file-mistakes-and-how-to-fix-them/
The text was updated successfully, but these errors were encountered: