-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scaling incorrect when using SCALE_NONE and scale_x / scale_y #754
Comments
@jeffski You might try setting scale to |
@JacksonRG I don't think that makes sense. If I scale the X axis, why would it scale the Y axis as well - unless you are maintaining aspect ratios. Scaling something by 50% should make it half the size, not quarter the size. Also this is a breaking change, it used to work as described. On upgrading to the latest version all our videos started rendering with elements smaller than they should be. |
Played about with this a bit more. It is definitely being scaled twice. If I comment out this code in QtImageReader.cpp (L249 - L257) then the image is scaled as expected to 50% of the original: libopenshot/src/QtImageReader.cpp Lines 249 to 257 in 111026d
This is for the QtImageReader which is easier to understand but something similar must be happening in the FFMpegReader too. |
Actually it doesn't seem correct with the code commented out. It does look like the image is scaled by 50% but the original image which is not scaled fills the viewport and the scaled image is 50% of that. |
2 things look suspicious here: |
Thank you so much for submitting an issue to help improve OpenShot Video Editor. We are sorry about this, but this particular issue has gone unnoticed for quite some time. To help keep the OpenShot GitHub Issue Tracker organized and focused, we must ensure that every issue is correctly labelled and triaged, to get the proper attention. This issue will be closed, as it meets the following criteria:
We'd like to ask you to help us out and determine whether this issue should be reopened.
Thanks again for your help! |
When using
SCALE_NONE
and then applyingscale_x
and/orscale_y
it appears as if images and videos are scaled twice. For example an image that is 1000px x 500px with a scale of 0.5 will result in an image displaying in the rendered video at 250px x 125px, not 500px x 250px.The code below demonstrates:
This is the test image used (1000px x 500px)
wave-1000x500.jpg
The output video is here (1280px x 720px):
output.mp4
I have tested this with FFMpegReader and the issue is the same.
Somewhere the scale must be being run twice.
The text was updated successfully, but these errors were encountered: