Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Encode experiences an output failure, it should let you return to your settings #2881

Closed
ferdnyc opened this issue Jul 21, 2019 · 1 comment
Labels
💡 enhancement This issue describes an improvement, enhancement, or feature request for OpenShot interface GUI / user interface issues (i.e. windows, buttons, scrolling, pop-ups, etc...) stale This issue has not had any activity in 60 days :(

Comments

@ferdnyc
Copy link
Contributor

ferdnyc commented Jul 21, 2019

Describe the new feature:
I was testing an export just now using hardware encoding, and I tried to encode using VA-API to my Nvidia card. It failed due to an error opening the device, which is fine, the failure was graceful and a dialog box came up to let me know about the issue.

However, after I closed that dialog, the Export window still proceeded to its "post-export" state where only the Done button is enabled, meaning my only option is to close the window.

Describe the solution you'd like:
Ideally, I'd like Export to re-enable the interface, and allow me to attempt the Export again after I change the Target setting to a different codec. (Hardware-accelerated NVENC, in my case, which is how I successfully exported the video after starting the process over from the beginning.)

The worst part is, it doesn't change the interface until after the error popup is closed. So even after the failure, even while that error message is showing, the Export dialog still shows the "Cancel" and "Export" buttons (disabled, like the rest of the interface). Then, when you close the error dialog, instead of reenabling those buttons, they suddenly disappear and the "Done" button takes their place.

Describe any alternatives you've considered:
Well, hell, if we're not going to let the user fix their export settings, we should just auto-close the window when the error popup is acknowledged. Leaving it there, inaccessible, and forcing them to click "Done" (when it's the only active control in the window)... that's just being mean.

Screenshots: (Optional)
Export, after closing the "Export Error" dialog.

image

@ferdnyc ferdnyc added 💡 enhancement This issue describes an improvement, enhancement, or feature request for OpenShot interface GUI / user interface issues (i.e. windows, buttons, scrolling, pop-ups, etc...) labels Jul 21, 2019
@stale
Copy link

stale bot commented Oct 26, 2020

Thank you so much for submitting an issue to help improve OpenShot Video Editor. We are sorry about this, but this particular issue has gone unnoticed for quite some time. To help keep the OpenShot GitHub Issue Tracker organized and focused, we must ensure that every issue is correctly labelled and triaged, to get the proper attention.
This issue will be closed, as it meets the following criteria: - No activity in the past 180 days - No one is assigned to this issue
We'd like to ask you to help us out and determine whether this issue should be reopened. - If this issue is reporting a bug, please can you attempt to reproduce on the latest daily build to help us to understand whether the bug still needs our attention. - If this issue is proposing a new feature, please can you verify whether the feature proposal is still relevant.
Thanks again for your help!

@stale stale bot added the stale This issue has not had any activity in 60 days :( label Oct 26, 2020
@stale stale bot closed this as completed Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 enhancement This issue describes an improvement, enhancement, or feature request for OpenShot interface GUI / user interface issues (i.e. windows, buttons, scrolling, pop-ups, etc...) stale This issue has not had any activity in 60 days :(
Projects
None yet
Development

No branches or pull requests

1 participant