Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openshotv2.5.1-dev2 blender-2.82a crash "can't use animated title" #3408

Closed
SebO-L opened this issue Apr 25, 2020 · 9 comments · Fixed by #3416
Closed

Openshotv2.5.1-dev2 blender-2.82a crash "can't use animated title" #3408

SebO-L opened this issue Apr 25, 2020 · 9 comments · Fixed by #3416
Labels
🐞 bug A bug, error, or breakage of any kind pending A PR has been submitted to fix the issue

Comments

@SebO-L
Copy link

SebO-L commented Apr 25, 2020

Describe the bug
OpenShot-v2.5.1-dev2-1587624156-15c3efb7-26b7db94-x86_64.AppImage blender-2.82a-linux64 AnimatedTitle crash
Can't use blender for animated Titled with the last version of OpenShot
Generate button is greyed
I use the daily build of Openshot because the last stable build is not working on my debian machine.
I download the last blender binary (2.82a) from the official site because the version in the stable debian package manager is too old (2.79)
I reproduced the same bug on Ubuntu 18.04 with the same package.

Steps to reproduce the behavior:

  1. Select the blender binary in Preferences
  2. Go to Title-> Animated Title
  3. Select one of the title "snow effect for example"
  4. The generate button is greyed

Expected behavior
Generation of my animated title with blender

System Details

Log Files

Exception / Stacktrace
No stacktrace found in log files

@ferdnyc
Copy link
Contributor

ferdnyc commented Apr 27, 2020

Gah, seems subprocess is unhappy with Blender printing non-ASCII pathnames, when the default encoding is detected as 'ascii'`. I believe #3413 will fix this even for Python 3.4.

@ferdnyc
Copy link
Contributor

ferdnyc commented Apr 27, 2020

@SebO-L Here's a link to an AppImage built with #3413 applied:

https://drive.google.com/file/d/1LIXaUEezQjiganUjr-DIvkn1Wvfc5gxi/view?usp=sharing

Could you test whether that solves this issue for you? If so I can merge the PR and this will be fixed in the Daily Builds. Thanks.

@ferdnyc ferdnyc added 🐞 bug A bug, error, or breakage of any kind pending A PR has been submitted to fix the issue labels Apr 27, 2020
@SebO-L
Copy link
Author

SebO-L commented Apr 27, 2020

@ferdnyc
Hi, sorry it did not solve the issue. In fact, I am not able to reproduce the error, because the patch create another bug.
Openshot is not able to find the blender executable any more. I did two different tries.
At first, I kept the blender binary in the download folder ("Téléchargement" in french) and it was not working.
Second try, as it seems to be related to ascii encoding I moved the binary in my home folder and create a symbolic link in /usr/local/bin. But, the result is the same, Openshot can't find blender binary.

I Attach openshot-qt.log and the blender -v command result
Regards,

openshot-qt.log
blender_verbose.txt

screenshot

@ferdnyc
Copy link
Contributor

ferdnyc commented Apr 27, 2020

Thanks for testing! I'm guessing this means it failed to run the Blender version check with the new code, the logs should tell me why.

@ferdnyc
Copy link
Contributor

ferdnyc commented Apr 27, 2020

*sigh* Or not, because there's no error logged at all. But it's pretty clear what the issue is. Because we can't pass encoding='utf-8' to subprocess.Popen() until Python 3.6, I tried to work around that by doing a .reconfigure(encoding='utf-8') on the stream after it was opened. Problem is, .reconfigure() isn't supported until Python 3.7! So, it's back to the drawing board.

...Stinkin' Python 3.4. 😠

@SebO-L
Copy link
Author

SebO-L commented Apr 27, 2020

OK,
BTW, as a workaround, I moved the blender binary in a folder without french character and it's working.(with OpenShot-v2.5.1-dev2-1587624156-15c3efb7-26b7db94-x86_64.AppImage)

So I don't know if it's useful for you to speed too much time on that bug nor to wait for the new python version.

Regards,

@ferdnyc
Copy link
Contributor

ferdnyc commented Apr 27, 2020

@SebO-L Great, I was going to suggest exactly that workaround.

But, no, we're stuck with Python 3.4 for the foreseeable future, so this has to be made to work with it — however convoluted and backwards that ends up forcing the code to be.

@ferdnyc
Copy link
Contributor

ferdnyc commented Apr 28, 2020

Ohhh-kay. This is an AppImage with #3416 integrated:

https://drive.google.com/file/d/1ipXiuDpUxz057jGtapgDh5XyvxtoZRqE/view?usp=sharing

I've already tested it myself, this time, but if you'd like to as well that'd be great. I'm pretty confident in this version of the fix, though, as I successfully rendered an animated title using a /var/tmp/Fjörd/blender symlink as my Blender path. 😉 Once #3416 is merged the Daily Builds will also include the fix.

Thanks for the helpful report(s)!

@SebO-L
Copy link
Author

SebO-L commented Apr 28, 2020

@ferdnyc Ok it's working now.
Thanks for your work !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug A bug, error, or breakage of any kind pending A PR has been submitted to fix the issue
Projects
None yet
2 participants