Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Local instance is trying to access S3 bucket with USE_LOCAL=TRUE #607

Open
3 tasks done
sebyakuya opened this issue Apr 17, 2024 · 3 comments
Open
3 tasks done
Assignees
Labels
bug Something isn't working up-for-grabs

Comments

@sebyakuya
Copy link

Issue Description

I managed to get a document signed locally but I had to remove everything related to S3, because I was getting mad.

I've spend most of the time trying to avoid the "Missing credentials in config, if using AWS_CONFIG_FILE, set AWS_SDK_LOAD_CONFIG=1" error because it was trying to connect to a non-existing S3 bucket, even though I had the USE_LOCAL variable set to TRUE. I think the problem is with the loading of the getPresignedURL function, which seems to be loaded even with USE_LOCAL=TRUE.

BTW I'm not really sure about why this fails, I'm just sharing the problems I had when trying to run this locally with the current instructions.

PD: Please update the documentation, it's very tough to guess some basic things to start a local instance:

  • I didn't know what a Parse server was, I had to guess how to create the first user and adding a role, I had to use parse-dashboard to do it (parse-dashboard --dev --appId opensignstgn --allowInsecureHTTP --masterKey XnAadwKxxByMr --serverURL "http://localhost:8080/app" --appName open_sign_server)
  • There's no indication to have the latest node/npm version to be able to make build, it would be nice to have
  • The .env.local_dev contains APP_ID=opensign instead of APP_ID=opensignstgn. Once I started using APP_ID=opensignstgn everything was smooth but this specific error message could be more descriptive
  • Does apps/OpenSignServer/app.yaml need to be updated if we are using docker-compose up?

Expected Behavior

If USE_LOCAL is set to TRUE when I go to sign a document it should load the PDF correctly.

Current Behavior

A "Failed to load PDF" error appears. I can see requests to a non-existing S3 bucket.

Steps to reproduce

  • Edit .env and set USE_LOCAL=TRUE
  • docker-compose up
  • Sign yourself menu
  • Load a PDF
  • Error message appears "Failed to load PDF" on draft page
  • Check network tab, see requests to AWS

Screenshots of the issue(optional)

No response

Operating System [e.g. MacOS Sonoma 14.1, Windows 11]

Windows 10

What browsers are you seeing the problem on?

Chrome

What version of OpenSign™ are you seeing this issue on? [e.g. 1.0.6]

1.4.2

What environment are you seeing the problem on?

Dev (localhost or vercel)

Please check the boxes that apply to this issue report.

  • I have searched the existing issues & discussions to make sure that this is not a duplicate.

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the existing issues & discussions to make sure that this is not a duplicate.
@andrew-opensignlabs
Copy link
Collaborator

@sebyakuya thanks for reporting this. We will be fixing it soon.

@nxglabs
Copy link
Contributor

nxglabs commented Apr 26, 2024

@sebyakuya this issue has been resolved. Can you please check and confirm?

@sebyakuya
Copy link
Author

Hi,

I've been trying to start from the staging branch but I'm finding the following error:

image

I've checked the OpenSignServer has that dependency in the package.json and that it's inside node_modules, I don't know why it's saying that it can't be found.

Steps:

  • Ensure you work with the latest NPM version
  • git checkout -- .
  • Ensure you are in the "staging" branch
  • Ensure .env.local_dev has default values
  • Make build
  • OpenSignServer container fails to start while the other containers are running fine

FYI I've been using tagged branch v1.4.2 these days without any problem which was my main issue, so if you consider this bug is solved or that the issue might come from my local node/npm installation it's fine by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working up-for-grabs
Projects
None yet
Development

No branches or pull requests

4 participants