Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description of Identifier rules wrong in documentation #809

Open
ClemensLinnhoff opened this issue May 7, 2024 · 1 comment · May be fixed by #812
Open

Description of Identifier rules wrong in documentation #809

ClemensLinnhoff opened this issue May 7, 2024 · 1 comment · May be fixed by #812
Milestone

Comments

@ClemensLinnhoff
Copy link
Contributor

Describe the bug

This is the definition of the Identifier in the documentation:

Has to be unique among all simulated items at any given time. For ground truth, the identifier of an item (object, lane, sign, etc.) must remain stable over its lifetime. Identifier values may be only be reused if the available address space is exhausted and the specific values have not been in use for several time steps. Sensor specific tracking IDs have no restrictions and should behave according to the sensor specifications.

It says, that every ID shall be globally unique except for sensor specific tracking IDs. This does not make much sense. A sensor ID is completely independent from object IDs or route IDs. Furthermore, sensor IDs depend on the sensor setup and are independent from the scenario, where the object IDs are defined. Same with the route IDs: They are defined in the map and are independent from sensor setup and scenario.

Describe the expected behavior

I propose:

  • Set rule is_globally_unique in all fields that are actually supposed to be globally unique (NOT sensor ID or tracking ID for example).
  • Change description of Identifier to state that the ID is only globally unique, if specified by the rule is_globally_unique.
  • Optional: Introduce new rule is_unique to specify uniqueness within the individual field
pmai added a commit that referenced this issue May 13, 2024
Addresses #809.

Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
pmai added a commit that referenced this issue May 13, 2024
Addresses #809.

Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
@jdsika
Copy link
Contributor

jdsika commented Jun 13, 2024

Introducing a new rule can be introduced in v3.7.1

@jdsika jdsika closed this as completed Jun 13, 2024
@jdsika jdsika reopened this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants