fix status of isError flag is incorrect

apache · Oct 12, 2017 · 6d1aade · 6d1aade
1 parent a5e62bf
commit 6d1aade
Showing 1 changed file with 20 additions and 1 deletion.
diff --git a/...org/skywalking/apm/collector/agentstream/worker/segment/cost/SegmentCostSpanListener.java b/...org/skywalking/apm/collector/agentstream/worker/segment/cost/SegmentCostSpanListener.java
@@ -21,7 +21,10 @@
 import java.util.ArrayList;
 import java.util.List;
 import org.skywalking.apm.collector.agentstream.worker.cache.ServiceCache;
+import org.skywalking.apm.collector.agentstream.worker.segment.EntrySpanListener;
+import org.skywalking.apm.collector.agentstream.worker.segment.ExitSpanListener;
 import org.skywalking.apm.collector.agentstream.worker.segment.FirstSpanListener;
+import org.skywalking.apm.collector.agentstream.worker.segment.LocalSpanListener;
 import org.skywalking.apm.collector.core.framework.CollectorContextHelper;
 import org.skywalking.apm.collector.core.util.TimeBucketUtils;
 import org.skywalking.apm.collector.storage.define.segment.SegmentCostDataDefine;
@@ -36,7 +39,7 @@
 /**
  * @author pengys5
  */
-public class SegmentCostSpanListener implements FirstSpanListener {
+public class SegmentCostSpanListener implements EntrySpanListener, ExitSpanListener, LocalSpanListener,FirstSpanListener {
 
     private final Logger logger = LoggerFactory.getLogger(SegmentCostSpanListener.class);
 
@@ -62,6 +65,22 @@ public void parseFirst(SpanObject spanObject, int applicationId, int application
         }
 
         segmentCosts.add(segmentCost);
+        isError = isError || spanObject.getIsError();
+    }
+
+    @Override
+    public void parseEntry(SpanObject spanObject, int applicationId, int applicationInstanceId, String segmentId) {
+        isError = isError || spanObject.getIsError();
+    }
+
+    @Override
+    public void parseExit(SpanObject spanObject, int applicationId, int applicationInstanceId, String segmentId) {
+        isError = isError || spanObject.getIsError();
+    }
+
+    @Override
+    public void parseLocal(SpanObject spanObject, int applicationId, int applicationInstanceId, String segmentId) {
+        isError = isError || spanObject.getIsError();
     }
 
     @Override public void build() {