Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track serviceworker issues to resolve #4458 #4460

Closed
FinnStutzenstein opened this issue Mar 5, 2019 · 4 comments
Closed

Track serviceworker issues to resolve #4458 #4460

FinnStutzenstein opened this issue Mar 5, 2019 · 4 comments

Comments

@FinnStutzenstein
Copy link
Member

The angular issue for this: angular/angular#20970
PR (currently work-in-progress): angular/angular#21842

If this is upstream and released, we can revert the changes in #4458 and use the registerImmediately strategy to load the SW.

@tsiegleauq
Copy link
Contributor

Thanks.
However, that might not be the only thing. We already tried to remove all setInterval and setTimeout from OpenSlides without ever reaching a stable ApplicationRef state

@FinnStutzenstein
Copy link
Member Author

see comment in #4458 : It may not be our mistake, becuase interval and setInterval are not used much and setTimeout should not be a problem..

@tsiegleauq
Copy link
Contributor

Was basically resolved in #4462
Since upstream stuff might change, I leave that open nevertheless. Perhaps we can clean up the app component after this was resolved upstream

@FinnStutzenstein
Copy link
Member Author

I guess we have not to change anything, even if the upstream gets more features. So I'll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants