Change scope calculation for committee members #2487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-peschke
requested changes
Jul 5, 2024
| @@ -30,7 +31,7 @@ def __repr__(self) -> str: | |||
| class UserScopeMixin(BaseServiceProvider): | |||
| def get_user_scope( | |||
| self, id_or_instance: int | dict[str, Any] | |||
| ) -> tuple[UserScope, int, str]: | |||
| ) -> tuple[UserScope, int, str, list[int]]: | |||
| """ | |||
| Parameter id_or_instance: id for existing user or instance for user to create | |||
| Returns the scope of the given user id together with the relevant scope id (either meeting, | |||
There was a problem hiding this comment.
Missing description of new return value
| lock_result=False, | ||
| use_changed_models=False, | ||
| ) | ||
| if user.get("organization_management_level") in ( |
There was a problem hiding this comment.
you forget to read the oml and additionally you should have a test to detect this
There was a problem hiding this comment.
- The oml is read right in this line at `user.get("organization_management_level")
- This code is in case the user is a super- or orga-admin because in this case he is implicitly also allowed to above any committee_admin for the sake of the user_scope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2448
Includes appropriate changes to get_user_scope presenter, should probably be used when making the appropriate amendments in the client