Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent color for hyperlinks between light/dark themes #2206

Closed
colinmahns opened this issue Apr 15, 2023 · 1 comment · Fixed by #2395
Closed

Inconsistent color for hyperlinks between light/dark themes #2206

colinmahns opened this issue Apr 15, 2023 · 1 comment · Fixed by #2395
Assignees
Labels
enhancement General enhancement which is neither bug nor feature
Milestone

Comments

@colinmahns
Copy link

During some testing with OpenSlides for my user base, we stumbled on this issue with the default color OpenSlides selects for themes being inconsistent between the light and dark themes. In our case, a primary color of a black from our branding guidelines has caused links to not be obvious and visible on items like the Home screen.

Steps to Reproduce:

    1. Set OpenSlides colors to the following:
  • Primary Color: 231F20
  • Accent Color: EC1F27
  • Warn Color: F06400
  1. Create some example text with hyperlinks in the Home screen (or text of an agenda item or motion).
  2. Toggle between light and dark mode

Expected behavior:
Hyperlinks should be the accent color regardless of theme mode.

Potential workaround:
Manual coloring of the text via the in-browser editor bypasses this issue but is time consuming for larger pages.

I've attached some images of the problem on our instance!
image (6)
Screenshot 2023-04-15 at 2 11 44 PM

@colinmahns colinmahns changed the title Inconsistent Color for Hyperlinks Inconsistent color for Hyperlinks Apr 15, 2023
@colinmahns colinmahns changed the title Inconsistent color for Hyperlinks Inconsistent color for hyperlinks between light/dark themes Apr 16, 2023
@rrenkert rrenkert added this to the 4.1 milestone May 23, 2023
@rrenkert rrenkert added the enhancement General enhancement which is neither bug nor feature label May 23, 2023
@Eich-hoernchen
Copy link
Collaborator

Eich-hoernchen commented Jun 5, 2023

to indicate a hyperlink the text should have an underline

by hovering the hyperlink the undeline should change into a smoother primary color, exept the primary color is a dark color in the darkmode, in this case it should be the accent color.

image

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General enhancement which is neither bug nor feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants