New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle data from new BTAX Version #637
Conversation
Thanks for the contribution @brittainhard. Can you update B-Tax to the new version, 0.1.9? |
@hdoupe you mean in the requirements file? |
Yes, the conda-requirements.txt file is where I've been setting |
@hdoupe I merged your code into this branch and found a bug. Looks like btax is relying on the old dropq code to submit, since its still using form data to submit. I can have this fixed quickly I think. |
@brittainhard thanks for catching this. The only validation that the webapp needs to do on TaxBrain data is to make sure that no extra parameters were submitted and all of the data parses. I think we could leave all of the |
@hdoupe i think the problem is with how webapp is now interacting with btax. I'm getting this error from the backend: I think we need to allow for btax to submit reforms in the old way. |
@brittainhard I opened a PR ( #651 ) on the 634_btax_dataframes branch. Is that you what you were asking me to do? |
@hdoupe yep, thats what i was looking for, thanks. |
Fix btax backend bug caused by PR #641
Closes #634