Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle data from new BTAX Version #637

Merged
merged 31 commits into from Sep 18, 2017
Merged

Handle data from new BTAX Version #637

merged 31 commits into from Sep 18, 2017

Conversation

brittainhard
Copy link
Contributor

Closes #634

@hdoupe
Copy link
Collaborator

hdoupe commented Sep 14, 2017

Thanks for the contribution @brittainhard. Can you update B-Tax to the new version, 0.1.9?

@hdoupe hdoupe mentioned this pull request Sep 14, 2017
5 tasks
@brittainhard
Copy link
Contributor Author

@hdoupe you mean in the requirements file?

@hdoupe
Copy link
Collaborator

hdoupe commented Sep 14, 2017

Yes, the conda-requirements.txt file is where I've been setting taxcalc versions.

@brittainhard
Copy link
Contributor Author

@hdoupe I merged your code into this branch and found a bug. Looks like btax is relying on the old dropq code to submit, since its still using form data to submit. I can have this fixed quickly I think.

@hdoupe
Copy link
Collaborator

hdoupe commented Sep 18, 2017

@brittainhard thanks for catching this. The only validation that the webapp needs to do on TaxBrain data is to make sure that no extra parameters were submitted and all of the data parses. I think we could leave all of the forms.py code as it was before #641 but add a taxbrain flag that tells the validation routine to skip over the min/max validation in taxbrain/forms.do_taxcalc_validations.

@brittainhard
Copy link
Contributor Author

@hdoupe i think the problem is with how webapp is now interacting with btax. I'm getting this error from the backend: Error: runner_json_tables() argument after ** must be a mapping, not float, in this file here: https://github.com/open-source-economics/B-Tax/blob/master/btax/run_btax.py.

I think we need to allow for btax to submit reforms in the old way.

@hdoupe
Copy link
Collaborator

hdoupe commented Sep 18, 2017

@brittainhard I opened a PR ( #651 ) on the 634_btax_dataframes branch. Is that you what you were asking me to do?

@brittainhard
Copy link
Contributor Author

@hdoupe yep, thats what i was looking for, thanks.

@brittainhard brittainhard merged commit e66ac88 into master Sep 18, 2017
@brittainhard brittainhard deleted the 634_btax_dataframes branch October 12, 2017 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants