Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CCC video to getting started page #724

Merged
merged 2 commits into from Nov 2, 2017

Conversation

jessmc
Copy link
Contributor

@jessmc jessmc commented Nov 1, 2017

Hi all,
Added the Cost of Capitol Calculator youtube video to the Getting Started page. Separated the videos with a bottom margin. Please let me know if you have any questions!
Thanks,
Jessica

@hdoupe
Copy link
Collaborator

hdoupe commented Nov 1, 2017

@jessmc This looks great, but there are two things that need to be changed:

  1. The "Cost of Capital" header is missing above the Cost of Capital video.
    screen shot 2017-11-01 at 4 03 25 pm

  2. You added a migrations file. While that should be added, I think we should do it in a separate PR.

cc @MattHJensen

@jessmc
Copy link
Contributor Author

jessmc commented Nov 2, 2017

Hi @hdoupe ,
I have added the title "Cost of Capital Calculator" and removed that migrations file. Thanks for your help!

@hdoupe
Copy link
Collaborator

hdoupe commented Nov 2, 2017

Looks great. Thanks @jessmc

@hdoupe hdoupe merged commit ae45b3e into ospc-org:master Nov 2, 2017
This was referenced Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants