Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse in all fields temporarily #745

Merged
merged 1 commit into from Nov 21, 2017
Merged

Conversation

GoFroggyRun
Copy link
Contributor

This PR collapse in all fields temporarily @hdoupe.

@hdoupe
Copy link
Collaborator

hdoupe commented Nov 21, 2017

@GoFroggyRun it looks like all of the fields are expanded instead of collapsed. Is that what you intended?

@MattHJensen
Copy link
Contributor

For those working on this, the desired behavior is:

  1. On ospc.org/taxbrain everything should be collapsed.
  2. On a preset input page (ospc.org/taxbrain/edit/*/, the sections with edited parameters should be open by default and others should be closed.

The preferred suboptimal outcome is for everything to always be open rather than to achieve (1) but not (2).

@GoFroggyRun
Copy link
Contributor Author

As @MattHJensen pointed out, a temporary solution would be to expand everything for the moment, before we have figured out the cause of the "collapse-expand" issue.

Speaking of causes, after looking at the front-end code, I feel like there's nothing wrong, nor changed, in the logic that takes care of the collapse-expand functionality. One possible reason I could think of that might have caused the issue is that TaxBrain interface mistakenly regards those newly-added parameters being somehow edited, and thus expanding them. @hdoupe would that be possible?

@hdoupe
Copy link
Collaborator

hdoupe commented Nov 21, 2017

LGTM. Thanks @GoFroggyRun

@hdoupe hdoupe merged commit e86c2cf into ospc-org:master Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants