Convert default values for boolean parameters from 1/0 to "True"/"False" #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #788 is on the test-app. I hope to merge this and push to production tomorrow if there are no objections. |
|
@hdoupe, I just tried entering False, False, False and got an error. Same with True, True, True
Looks like the problem is the spaces after the commas, which are fine with other parameters. |
Merged
|
Thanks for the bug report @MattHJensen. I just updated the test app with the bug fix. |
|
@hdoupe, everything is looking good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts 1/0 values back to boolean variables and serializes them. PolicyBrain reads the default GUI parameter values from Tax-Calculator's
default_datafunction. This line in parameters.py converts boolean parameters from true/false to 1/0. This treatment is currently only applied toDependentCredit_before_CTCbut will be applied to the other comma separated boolean variables as they are added.Before this PR, the default parameter value for
DependentCredit_before_CTCwas shown as:Behavior introduced by this PR shows:
