Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds data source to file input page, refactors reform submission, and improves tests #847

Merged
merged 21 commits into from Mar 14, 2018

Conversation

hdoupe
Copy link
Collaborator

@hdoupe hdoupe commented Mar 14, 2018

This PR does three things:

  1. Adds the data source to the file input page using the same approach as the GUI input page
  2. Refactors the reform submission to the worker nodes so that the post data is stored in a namedtuple instead of a dictionary. This replaces a combination of dictionaries and tuples with the class-like namedtuple. In my opinion, this enhances the readability of the code. I'm interested in others thoughts on this though.
  3. In order to utilize pytest's parameterize functionality in class methods, the class has to inherit from object. Since many methods needed to be tested with both data_source arguments ('PUF' and 'CPS') and there wasn't much benefit from using django.TestCase, I made this change. For now, this only applies to the TaxBrain static model views tests. However, future PR's should propagate this change to the other views test classes.

@hdoupe hdoupe merged commit 93d1bf0 into ospc-org:master Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant