Add CCC start year drop-down #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoFroggyRun
reviewed
Mar 16, 2018
static/js/btax.js
Outdated
| $('#current-year-alert').removeClass('hidden'); | ||
| var currentYear = $('#start-year-select').val(); | ||
| $('#start-year-select').change(function(e) { | ||
| $('#current-year-link').attr('href', '/taxbrain/?start_year=' + $(this).val()); |
There was a problem hiding this comment.
@hdoupe After changing '/taxbrain/?start_year=' to '/ccc/?start_year=' on my local, I was able to have the dialogue popping up and working.
There was a problem hiding this comment.
Nice, thanks @GoFroggyRun. Everything is looking good now.
added 7 commits
March 16, 2018 15:02
This was referenced Mar 21, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a drop down menu for the start year in the CCC.
@GoFroggyRun I'm having trouble getting the java script code to link up with the html code. That is the dialogue box doesn't change when I change the start year. Do you have any suggestions?
Also, I removed the staticfiles and fixed the gitignore so that they aren't stored anymore.
cc @jdebacker