Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add necessary steps to setup instructions #902

Merged
merged 2 commits into from Jun 14, 2018

Conversation

lucassz
Copy link
Contributor

@lucassz lucassz commented Jun 14, 2018

I noticed while setting up a local installation of PolicyBrain that these steps are definitely needed (to install prerequisite packages TaxBrain and B-Tax).

@hdoupe
Copy link
Collaborator

hdoupe commented Jun 14, 2018

@lucassz Thanks for opening up this PR. The instructions can always be improved.

I have a question about this line:

conda install -c ospc taxcalc btax

These packages should be installed in the python_env_build.sh script. Were they not in the pb_env conda environment?

@lucassz
Copy link
Contributor Author

lucassz commented Jun 14, 2018

These packages should be installed in the python_env_build.sh script. Were they not in the pb_env conda environment?

@hdoupe I remember having to perform that step manually even in the environment, but you are right that they should have been installed according to the condo-requirements.txt file.

@hdoupe
Copy link
Collaborator

hdoupe commented Jun 14, 2018

What's the output when you run source activate pb_env && conda list taxcalc?

@lucassz
Copy link
Contributor Author

lucassz commented Jun 14, 2018

It seems to show up fine in that case, so it's possible I was doing something wrong before.

@hdoupe
Copy link
Collaborator

hdoupe commented Jun 14, 2018

Ok, cool. In that case, you can remove the extra conda install step and we can merge this PR with the link addition.

@lucassz
Copy link
Contributor Author

lucassz commented Jun 14, 2018

@hdoupe Done.

@hdoupe
Copy link
Collaborator

hdoupe commented Jun 14, 2018

LGTM. Thanks for the contribution @lucassz

@hdoupe hdoupe merged commit 4bcd655 into ospc-org:master Jun 14, 2018
@lucassz lucassz deleted the instructions branch June 15, 2018 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants