Cleans up input parameter save and display logic for dynamic app #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucassz
suggested changes
Jun 27, 2018
RELEASES.md
Outdated
| @@ -22,6 +22,7 @@ Release 1.7.0 on 2018-06-?? | |||
|
|
|||
| **Bug Fixes** | |||
| - [#904](https://github.com/OpenSourcePolicyCenter/PolicyBrain/pull/904) - Fix formatting of the first line in CSV output for better compatibility - Lucas Szwarcberg | |||
| - [#912](https://github.com/OpenSourcePolicyCenter/PolicyBrain/pull/912) - Cleans up input parameter save and display logic for dyanamic app - Hank Doupe | |||
There was a problem hiding this comment.
Yep, good catch. Thanks @lucassz
hdoupe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
dynamic_input_parameterstaxbrain_model.json_text.save()(who knew all the ways you had to save a django relation?)set_fieldsandto_jsonto createraw_assumption_textfield if it is not there@lucassz can you review this?