Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/11997 #29

Merged
merged 2 commits into from Oct 23, 2016
Merged

Feature/11997 #29

merged 2 commits into from Oct 23, 2016

Conversation

gcutrini
Copy link
Member

Realm integration on watchOS caused the weight of the distributed app to exceed the allowed 50mb.
This pull request reverts #23 and fixes integration with features introduced in #26.

…e/feature/11963"

This reverts commit eb041fc, reversing
changes made to 5b40cc5.

# Conflicts:
#	OpenStack Summit/OpenStackSummitWatch Extension/SpeakersInterfaceController.swift
#	OpenStack Summit/OpenStackSummitWatch/Base.lproj/Interface.storyboard
@jimmytipit jimmytipit merged commit 85ca253 into develop Oct 23, 2016
@gcutrini gcutrini deleted the feature/11997 branch October 23, 2016 20:38
@colemancda
Copy link
Contributor

Well... all that work for nothing. I guess we need to migrate to CoreData asap.

@colemancda
Copy link
Contributor

So I understand this reverts #23 (bummer) I dont understand exactly how this affects #26 ?

@gcutrini
Copy link
Member Author

Yeah, I really appreciate the work on this and was sorry had to revert, but the included framework caused the watch app build to be above the 50mb limit.
The fact that we had to revert gives us yet another reason to move off of Realm.

@colemancda
Copy link
Contributor

That explains reverting #23, but how does this affect #26 ? Is that functionality still there?

@gcutrini
Copy link
Member Author

The filtering introduced on #26 relied upon Realm.
Just needed to make some modifications to work without it.

Actually #26 solves much of hour memory issues since we are only listing filtered events.
Works great by the way.

@colemancda colemancda mentioned this pull request Oct 23, 2016
@colemancda
Copy link
Contributor

Great! So the app is usable without Realm and we have Event Filtering. This means the app shouldn't crash during the summit and we can work on CoreData integration after the Barcelona summit (which starts in 2 days).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants