Make filter aware of changes in cache (11794) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcutrini
requested changes
Sep 21, 2016
colemancda
commented
Sep 21, 2016
|
|
||
| fallthrough | ||
|
|
||
| case .ActiveTalks: | ||
|
|
||
| FilterManager.shared.filter.value.didChangeActiveTalks = true |
There was a problem hiding this comment.
@gcutrini Here is am setting didChangeActiveTalks to true.
There was a problem hiding this comment.
@gcutrini Are you seeing an issue?
Clearing all active filters will not set didChangeActiveTalks, thus automatically reenabling the Hide Past Talks filter on next timer update.
There was a problem hiding this comment.
Sorry, not on cell's toggle selection, but when clearing filters from event view controller.
There was a problem hiding this comment.
Thanks! I didn't think of that xD
There was a problem hiding this comment.
fixed, pls test and approve
gcutrini
approved these changes
Sep 21, 2016
|
Merged! Great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently filter are statically created and shared across view controllers that use it; not being aware of data changes in the cache.
Say we get a data update adding one event to a track, that track won't show in filters.
We need to make filters aware of changes in model data.