Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mutil_get not aviliable in opentsdb2.4.0 #1768

Open
lloverj opened this issue Sep 5, 2019 · 9 comments
Open

mutil_get not aviliable in opentsdb2.4.0 #1768

lloverj opened this issue Sep 5, 2019 · 9 comments

Comments

@lloverj
Copy link

lloverj commented Sep 5, 2019

in opentsdb2.4, I want to use mutil-get,but fond in TsdbQuery.java ,multiget_with_search can't set.
so mutil-get can't use.
/** Whether or not to use the search plugin for multi-get resolution. */
private boolean multiget_with_search;

if (use_multi_gets && override_multi_get && multiget_with_search) {
  row_key_literals_list = Lists.newArrayList();
}

      if (filters != null) {
        if (use_multi_gets && override_multi_get && multiget_with_search) {

}
MultiGetQuery.java
if (tags == null) {
throw new IllegalArgumentException("Tags list cannot be null or empty");
}

@johnewing1
Copy link
Contributor

What did the query that threw that exception look like ?

@lloverj
Copy link
Author

lloverj commented Sep 9, 2019

What did the query that threw that exception look like ?

Tags list cannot be null or empty

@lloverj
Copy link
Author

lloverj commented Sep 9, 2019

config is :
tsd.query.multi_get.enable = true
tsd.query.multi_get.batch_size = 1024
tsd.query.multi_get.concurrent = 20
tsd.query.multi_get.get_all_salts = true

@lloverj lloverj changed the title mutil-get not aviliable mutil_get not aviliable in opentsdb2.4.0 Sep 9, 2019
@Betula-L
Copy link

Betula-L commented Sep 26, 2019

+1 @johnewing1

Exception stack is as follow,
···
Sep 26 17:18:53 localhost tsdb[62136]: 2019-09-26 17:18:53,825 ERROR [OpenTSDB I/O Worker #52] QueryRpc: Query exception:
Sep 26 17:18:53 localhost tsdb[62136]: java.lang.IllegalArgumentException: Tags list cannot be null or empty
Sep 26 17:18:53 localhost tsdb[62136]: at net.opentsdb.core.MultiGetQuery.(MultiGetQuery.java:175) ~[tsdb-2.4.0.jar:b5133bd]
Sep 26 17:18:53 localhost tsdb[62136]: at net.opentsdb.core.TsdbQuery.findSpansWithMultiGetter(TsdbQuery.java:844) ~[tsdb-2.4.0.jar:b5133bd]
Sep 26 17:18:53 localhost tsdb[62136]: at net.opentsdb.core.TsdbQuery.runAsync(TsdbQuery.java:745) ~[tsdb-2.4.0.jar:b5133bd]
Sep 26 17:18:53 localhost tsdb[62136]: at net.opentsdb.tsd.QueryRpc$1BuildCB.call(QueryRpc.java:294) ~[tsdb-2.4.0.jar:b5133bd]
Sep 26 17:18:53 localhost tsdb[62136]: at net.opentsdb.tsd.QueryRpc$1BuildCB.call(QueryRpc.java:286) ~[tsdb-2.4.0.jar:b5133bd]
Sep 26 17:18:53 localhost tsdb[62136]: at com.stumbleupon.async.Deferred.doCall(Deferred.java:1278) ~[async-1.4.0.jar:na]
Sep 26 17:18:53 localhost tsdb[62136]: at com.stumbleupon.async.Deferred.addCallbacks(Deferred.java:688) ~[async-1.4.0.jar:na]
Sep 26 17:18:53 localhost tsdb[62136]: at com.stumbleupon.async.Deferred.addCallback(Deferred.java:724) ~[async-1.4.0.jar:na]
Sep 26 17:18:53 localhost tsdb[62136]: at net.opentsdb.tsd.QueryRpc.handleQuery(QueryRpc.java:319) [tsdb-2.4.0.jar:b5133bd]
Sep 26 17:18:53 localhost tsdb[62136]: at net.opentsdb.tsd.QueryRpc.execute(QueryRpc.java:117) [tsdb-2.4.0.jar:b5133bd]
Sep 26 17:18:53 localhost tsdb[62136]: at net.opentsdb.tsd.RpcHandler.handleHttpQuery(RpcHandler.java:282) [tsdb-2.4.0.jar:b5133bd]
···

@johnewing1
Copy link
Contributor

Can you post what the query you are trying to run is ? It's hard work out what's going wrong without it.

What are you sending to /api/query that's getting that response back ?

@Betula-L
Copy link

Betula-L commented Sep 27, 2019

curl http://10.69.33.36:4242/api/query -H "Content-Type:application/json" -X POST -d @-

{
    "start": 1568412279,
    "end": 1569412579,
    "queries": [
        {
            "aggregator": "none",
            "metric": "bs__performance__candidates__sum",
            "rate": "true",
            "tags": {
                "app": "*"
            }
        }
    ]
}

This query is as followed as http://opentsdb.net/docs/build/html/api_http/query/index.html

If multi_get disabled it works well, while it is broken if multi_get was on.

@anonthing
Copy link
Contributor

How are you using the search plugin?

@Betula-L
Copy link

Sorry. I got it. There must be set some search plugin.

@Betula-L
Copy link

However, Tags list cannot be null or empty error message is so confused. Actually, it is caused by no search plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants