Fixed incorrect result of Count Downsampler when setting Rollup data #2258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When using Count Downsampler in an environment where Rollup data is pre-aggregated, incorrect results are returned.
In the case of Raw data, the number of valid data that existed during the time of the Downsample target is being counted.
This implementation is considered correct.
However, for Rollup data, this value should be output since pre-aggregated data already exists.
The existing implementation does not yield the correct aggregate data because Count Downsample is done in the same process as Raw data, even in cases where Rollup data is used.
Resolution
When Count Downsample is used and Rollup data is used, fixed to output the value of pre-aggregated data.