[Bug]: Without hardware acceleration, switching from Arabic to English results in black palette.

[PeterN]

Version of OpenTTD

master-g3e86f337a8

Expected result

Palette should not be affected by switching language.

Actual result

Palette is reset to black, only animated pixels are updated.

This only occurs when default sprite font used (but truetype antialiasing is enabled) and hardware acceleration is disabled, so the win32 video driver is in use rather than win32-opengl.

When switching to Arabic, the game automatically switches to using a truetype font. When switching back to English, the game automatically switches back to using the sprite font. Because antialiasing is enabled, this also causes the blitter to switch from 8bpp to 32bpp and then back to 8bpp.

Presumably a palette initialization is missing in this case.

Steps to reproduce

1. In the config, enable truetype antialiasing, but don't enable a truetype font.
2. Disable hardware acceleration (restart if necessary.)
3. Open game settings and set to Arabic.
4. Reset back to English (assumptions!) or any language that is supported by the sprite font.

[glx22]

Confirmed, but support8bpp needs to not be set to no.
Needs to be tested on other OS too.

Switching from French to Arabic

[2022-10-16 03:02:48] dbg: [fontcache] Font is missing glyphs to display char 0x648 in medium font size
[2022-10-16 03:02:53] dbg: [driver] Switching blitter from '8bpp-optimized' to '32bpp-sse2-anim'...
[2022-10-16 03:02:53] dbg: [driver] Successfully loaded blitter '32bpp-sse2-anim'
[2022-10-16 03:02:53] dbg: [driver] Successfully switched to 32bpp-sse2-anim.

Switching back to French

[2022-10-16 03:03:18] dbg: [driver] Switching blitter from '32bpp-sse2-anim' to '8bpp-optimized'...
[2022-10-16 03:03:18] dbg: [driver] Successfully loaded blitter '8bpp-optimized'
[2022-10-16 03:03:18] dbg: [driver] Successfully switched to 8bpp-optimized.

and everything is black except animated pixels.