[Bug]: Error messages are bigger as of the recent UI changes

[James103]

Version of OpenTTD

cbb2d53 on Windows 10, 64-bit

Expected result

Error messages should be about the same size as before the recent UI changes / release 12.2 and older.

One line:

Two lines:

Actual result

Error messages are significantly bigger (wider and taller) compared to 12.2 and older.
This happens even on 1x interface scaling which all screenshots were taken at.

One line:

Two lines:

Steps to reproduce

1. Start OpenTTD.
2. Trigger any error message.
3. Notice the message is significantly bigger compared to in older releases.

[PeterN]

Bug, or feature?

[ldpl]

Vertical feature horizontal bug xD

[PeterN]

If you want to play with and suggest a better size, it's the new modalpopup dimension, defined in widget.cpp:152.

Edit: This dimension is used by ErrmsgWindow, QueryWindow, and any of the progress-bar windows.

Might be sufficient to use the frametext dimension on ErrmsgWindow instead, to leave the rest as is.

[2TallTyler]

I'd expect a two-line message to be taller than a one-line message, and the old message appears to have been lacking proper text padding.

Not a bug, although PRs are open if somebody wants to resize it. 🙂