Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10257: Incorrect wire position on sloped bridge heads. #10258

Merged
merged 1 commit into from Dec 19, 2022

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Dec 18, 2022

Motivation / Problem

See #10257. El-rail wire position is incorrect on south-facing sloped bridge heads.

image

Description

The cause of this is alluded to in the comments:

Also note that the result of GetSlopePixelZ() is very special for bridge-ramps

This PR resolves this issue by rounding the z value to the nearest whole height-level increment, and adjusting z-offsets as appropriate.

image

image

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@PeterN PeterN merged commit dde15a4 into OpenTTD:master Dec 19, 2022
@PeterN PeterN deleted the elrail-fix-10257 branch December 19, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants