Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10263, ccefa76: [scripts] restore tile validation for commands #10269

Merged
merged 1 commit into from Dec 21, 2022

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Dec 21, 2022

Motivation / Problem

Scripts used to use DoCommandPInternal() which performed tile validation, but in the new templated framework the validation is bypassed.

Description

Restore the validation.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

michicc
michicc previously approved these changes Dec 21, 2022
@glx22
Copy link
Contributor Author

glx22 commented Dec 21, 2022

Added a regression check for that. Output in unpatched is:

1: 9298: -   BuildVehicle():       1048575
1: 9298: + Assertion failed: tile < MapSize(), file D:\developpement\GitHub\glx22\OpenTTD\src\tile_map.h, line 98'

@glx22 glx22 merged commit c179c10 into OpenTTD:master Dec 21, 2022
@glx22 glx22 deleted the fix_10263 branch December 21, 2022 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants