Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NRT road stop graphics are incomplete #10271

Open
PikkaBird opened this issue Dec 21, 2022 · 3 comments
Open

NRT road stop graphics are incomplete #10271

PikkaBird opened this issue Dec 21, 2022 · 3 comments
Labels
component: NewGRF This issue is related to NewGRFs enhancement Issue would be a good enhancement; we accept Pull Requests!

Comments

@PikkaBird
Copy link

PikkaBird commented Dec 21, 2022

Version of OpenTTD

13.0 b2

Expected result

NewRoadTypes allows providing custom depot sprites per roadtype; allows replacing the ground tile for stops per roadtype; but does not currently allow replacing the roadstop structure sprites per roadtype.

Roadtype Action 3 Cargo 0A should be extended with an optional 36-sprite version, which in addition to the four groundtiles for non-drive-through stops, also includes versions of:

  • The 12 default bus stop sprites from sprite 2696.
  • The 12 default truck stop sprites from sprite 2712.
  • The 8 bus and truck drive-through stops from Action 5 type 11.

The 36-sprite version should also be available to tramtypes, with tram stops taking precedence for combined stop tiles.

This is a lightweight NewGRF feature which will allow authors to provide road- and tramtype-appropriate default graphics. It does not, as far as I can tell, conflict with a full newroadstops feature being introduced in the future. It has the nice side effect of allowing default road stops to be desert/snow aware.

Actual result

Crumpleworth Transport, 1950-10-29

A test grf is attached which replaces the default roadstop graphics with red blocks, and adds two roadtypes; one which just uses a four-sprite Cargo 0A to replace the ground tile for stops, and one with the proposed 36-sprite version, which replaces the red block stops with green and blue blocks for buses and trucks, respectively.

busstoptest.zip

Steps to reproduce

Load a newroadtype sets with very different road types, and wonder why they all have the same stop graphics.

@2TallTyler 2TallTyler added enhancement Issue would be a good enhancement; we accept Pull Requests! component: NewGRF This issue is related to NewGRFs labels Dec 21, 2022
@PeterN
Copy link
Member

PeterN commented Dec 21, 2022

I like a proposal which also proproses the spec :-)

@2TallTyler
Copy link
Member

And includes a test GRF for said proposed spec! 👍

@Ufiby
Copy link

Ufiby commented Dec 21, 2022

Good idea. If implemented, I would do it with pleasure 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: NewGRF This issue is related to NewGRFs enhancement Issue would be a good enhancement; we accept Pull Requests!
Projects
None yet
Development

No branches or pull requests

4 participants